Skip to content

remove dead jwt field from session types#72

Merged
fabracht merged 2 commits into
mainfrom
fix/remove-dead-session-jwt-field
May 24, 2026
Merged

remove dead jwt field from session types#72
fabracht merged 2 commits into
mainfrom
fix/remove-dead-session-jwt-field

Conversation

@fabracht
Copy link
Copy Markdown
Contributor

Summary

Closes #71. The jwt field on Session/NewSession/SessionRef was written and cloned but never read after #70handle_logout switched to session.jti, destroy_others_by_canonical_id returns JTIs, and handle_ticket mints fresh ticket JWTs from session claims rather than the stored one. The session-time JWT was never returned to the client either (callback/register/login all set just the session-id cookie + a user-info JSON body — no JWT).

Dropped the field from all three structs and removed mint_callback_jwt entirely; its three callers now just generate a JTI inline via JtiRevocationStore::generate_jti(). handle_login's no-longer-needed ProviderIdentity construction and verified destructure also dropped.

No behavior change. Pure cleanup; types affected are crate-private (only SessionStore and JtiRevocationStore are re-exported).

Test plan

  • cargo make clippy — clean (workspace + no-default + wasm + default)
  • cargo test -p mqdb-agent --features http-api session_store — 8/8 pass
  • cargo make dev — only failure is the pre-existing mqtt_transport_heartbeat_roundtrip (local port 11883 held by a long-running mqdb agent), unrelated to this branch

@fabracht fabracht merged commit a8ffe6f into main May 24, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove dead jwt field from Session/NewSession/SessionRef

1 participant