remove dead jwt field from session types#72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #71. The
jwtfield onSession/NewSession/SessionRefwas written and cloned but never read after #70 —handle_logoutswitched tosession.jti,destroy_others_by_canonical_idreturns JTIs, andhandle_ticketmints fresh ticket JWTs from session claims rather than the stored one. The session-time JWT was never returned to the client either (callback/register/login all set just the session-id cookie + a user-info JSON body — no JWT).Dropped the field from all three structs and removed
mint_callback_jwtentirely; its three callers now just generate a JTI inline viaJtiRevocationStore::generate_jti().handle_login's no-longer-neededProviderIdentityconstruction andverifieddestructure also dropped.No behavior change. Pure cleanup; types affected are crate-private (only
SessionStoreandJtiRevocationStoreare re-exported).Test plan
cargo make clippy— clean (workspace + no-default + wasm + default)cargo test -p mqdb-agent --features http-api session_store— 8/8 passcargo make dev— only failure is the pre-existingmqtt_transport_heartbeat_roundtrip(local port 11883 held by a long-running mqdb agent), unrelated to this branch